clear the modifier keys on exiting the focused window #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixes the issue when you are type a key command to leave a window like ALT+tab. The window will receive just ALT and it will remain stuck after you refocus.
Owner
|
Thanks! |
|
has this only fixed this under the wayland backend and only on linux, or was this a wayland-only problem? i'm pretty sure there's this exact issue but for macroquad, which is likely just originating in miniquad: not-fl3/macroquad#547 happens on windows as well, clearing the mods when exiting the focused window also doesn't seem quite correct, other libraries like SDL2 or the like properly handle releasing keys when you've moused off the window, so this feels and looks like a little bit of a bandaid fix that will not actually fix the problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to clear the mods otherwise they can be released outside the window's focus and stay on when the window is refocused.
btw when you get a chance, please approve issue #517, ty!