sqlite: fix crash session extension callbacks with workers #59848
+131
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59848 +/- ##
==========================================
+ Coverage 88.26% 88.29% +0.02%
==========================================
Files 701 701
Lines 206774 206774
Branches 39778 39782 +4
==========================================
+ Hits 182514 182570 +56
+ Misses 16298 16228 -70
- Partials 7962 7976 +14
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Sep 10, 2025
Co-authored-by: Anna Henningsen <[email protected]>
Co-authored-by: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that static std::function variables are used to store callbacks. This causes problems when SQLite is used (also) used from a worker and can result in a crash.
This PR stack allocates the callbacks and passes it along to
sqlite3changeset_applyvia the context argument.It also adds a regression test which crashes out before this change.
Lastly some functionality that is uses in
test/parallel/test-sqlite.jsis now also needed intest/parallel/test-sqlite-session.jsso I factored that out to a different file.