Skip to content

src: ensure v8::Eternal is empty before setting it #59825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

src: ensure v8::Eternal is empty before setting it #59825

merged 1 commit into from
Sep 11, 2025
+1 −0

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 9, 2025

V8 does not check this for us, but this is a requirement of the API.

@addaleax
src: ensure v8::Eternal is empty before setting it
627b2f1 
V8 does not check this for us, but this is a requirement of the API.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 9, 2025
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69159/

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.28%. Comparing base (d58343e) to head (627b2f1).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59825      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.01%     
==========================================
  Files         701      701              
  Lines      206784   206784              
  Branches    39762    39765       +3     
==========================================
+ Hits       182528   182559      +31     
+ Misses      16304    16243      -61     
- Partials     7952     7982      +30
Files with missing lines Coverage Δ
src/env-inl.h 93.61% <ø> (-0.43%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas
legendecas approved these changes Sep 9, 2025
View reviewed changes
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69170/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 220baad into nodejs:main Sep 11, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 220baad

@anonrig
Copy link
Member

anonrig commented Sep 11, 2025

@addaleax what's the difference between v8::Global and v8::Eternal? if you don't mind me asking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@jasnell jasnell jasnell approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @anonrig @jasnell @legendecas @juanarbol