http: recognize HTTP2/PRI upgrade #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also: I did a performance test, no noticeable change |
RFC7540 describes the false PRI method, part of the HTTP/2 Connection Preface. It mimics a regular HTTP/1 request, but in reality is an upgrade request with the bytes PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n When we see this method, we should hand-off as we do any other upgrade.
|
I should have run the tests and the linter. Fixed. |
|
@indutny any thoughts here? |
indutny
pushed a commit
that referenced
this pull request
Jan 12, 2021
RFC7540 describes the false PRI method, part of the HTTP/2 Connection Preface. It mimics a regular HTTP/1 request, but in reality is an upgrade request with the bytes PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n When we see this method, we should hand-off as we do any other upgrade. PR-URL: #80 Reviewed-By: Fedor Indutny <[email protected]>
|
Landed in 73d7bd9 |
alex-dev-2012
added a commit
to alex-dev-2012/llhttp
that referenced
this pull request
Jul 29, 2025
RFC7540 describes the false PRI method, part of the HTTP/2 Connection Preface. It mimics a regular HTTP/1 request, but in reality is an upgrade request with the bytes PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n When we see this method, we should hand-off as we do any other upgrade. PR-URL: nodejs/llhttp#80 Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC7540 describes the false PRI method, part of the HTTP/2 Connection
Preface. It mimics a regular HTTP/1 request, but in reality is an upgrade
request with the bytes
When we see this method, we should hand-off as we do any other upgrade.