update to struct-buffer v6 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahm
commented
Feb 2, 2025
Owner
Author
noahm
left a comment
There was a problem hiding this comment.
Did some light testing; all works well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previews what the API changes look like from the perspective of this app when consuming the new pre-release version over here: noahm/struct-buffer#1
The changes are pretty minor, aside from it being a lot easier to make our custom
enabledPanels_ttype in a style that fits the rest of the system a bit better. The names that got passed into the struct constructors are gone completely, and the options on encode/decode are a bit more imperative.Needs a bit of extra manual testing from this point, but it should be ready to go otherwise.