feat: add ability to mock requests in record mode #2457
+172
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds useful! Looking forward to it |
|
what needs to happen for this to get reviewed/merged? My use case: Make it a lot more visible to engineers that un-mocked network requests are happening, even in files that have some mocked requests already. The goal would be to get that number down to zero in unit tests. |
|
The problem with this is its using So it mistakenly forwards to mocked request instead of sending it to internet and recording it. https://github.com/ava-labs/nock/blob/allow_mocked/lib/recorder.js#L246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Description
Adds a new
allow_mockedrecorder option.If
true, the recorder will only record unmatched requests. Calls to matched requests will return the mocked response and will not be recorded.This is useful when you want your tests to use specific responses for certain requests but to record the rest.