Skip to content

Fix Unicode test timeout (for real this time!) #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nlohmann merged 2 commits into from
Jul 28, 2022
Merged

Fix Unicode test timeout (for real this time!) #3614

nlohmann merged 2 commits into from
Jul 28, 2022

Conversation

@falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Jul 27, 2022

The previous attempt didn't quite do the job because TIMEOUT_AFTER_MATCH doesn't work as expected. This sets the timeout of test-unicode4 to twice the default (i.e., 3000s).

Fixes #3579.

@coveralls
Copy link

coveralls commented Jul 27, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling cfcee93 on falbrechtskirchinger:fix-timeout into 2d48a4d on nlohmann:develop.

nlohmann
nlohmann reviewed Jul 28, 2022
View reviewed changes
nlohmann
nlohmann approved these changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 28, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 28, 2022
@nlohmann nlohmann merged commit 5520761 into nlohmann:develop Jul 28, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the fix-timeout branch July 28, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels

release item: 🔨 further change

Projects

None yet

Milestone

Release 3.11.0

Development

Successfully merging this pull request may close these issues.

unicode4 test consistently fails on RISC-V hardware

3 participants

@falbrechtskirchinger @coveralls @nlohmann