Skip to content

Conversation

@nlohmann
Copy link
Owner

@nlohmann nlohmann commented Nov 25, 2024

Closes #4026. Closes #4289. Closes #4279.

@coveralls
Copy link

coveralls commented Nov 25, 2024

Coverage Status

coverage: 99.649%. remained the same
when pulling 7da52e9 on documentation-updates
into 9f60e85 on develop.

@github-actions github-actions bot added the CMake label Nov 30, 2024
@github-actions github-actions bot removed the tests label Nov 30, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 5, 2024
@nlohmann nlohmann marked this pull request as ready for review December 7, 2024 22:24
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Dec 7, 2024
@nlohmann nlohmann requested a review from gregmarr December 7, 2024 22:25
@nlohmann nlohmann requested a review from gregmarr December 9, 2024 19:44
Copy link
Contributor

@gregmarr gregmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small redundancy, otherwise looks good.

@nlohmann nlohmann merged commit 549c79b into develop Dec 9, 2024
121 checks passed
@nlohmann nlohmann deleted the documentation-updates branch December 9, 2024 22:02
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CMake documentation L review needed It would be great if someone could review the proposed changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ordered json pointer corruption Program crashes with ordered_json, but works fine with json Missing requirement on plantuml binary package

4 participants