Skip to content

Repair Skybox #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2020
Merged

Repair Skybox #44

merged 4 commits into from
Dec 4, 2020

Conversation

@njibhu
Copy link
Owner

@njibhu njibhu commented Dec 3, 2020 •
edited
Loading

Repair the skybox implementation on the MapExplorer example and the Explorer

TODO:

  • Check after merging the Stats the FPS impact of the Skybox

@njibhu
Copy link
Owner Author

njibhu commented Dec 4, 2020

Performance is identical with and without the skybox. Tested on Firefox with ClawIsland

@njibhu njibhu merged commit f939dc3 into master Dec 4, 2020
@njibhu njibhu deleted the skyboxes branch December 4, 2020 01:42
@njibhu njibhu linked an issue Dec 4, 2020 that may be closed by this pull request
[Library] Skybox code is broken #27
Closed
njibhu added a commit that referenced this pull request Dec 18, 2020
@njibhu
Skybox (#44)
b9a2cb0 
* --wip-- [skip ci]

* --wip-- [skip ci]

* Fix existing implementation of skybox

* Add skybox to Explorer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Library] Skybox code is broken

2 participants

@njibhu