Skip to content

feat(vite): basic rolldown-vite support #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pi0 merged 4 commits into from
Nov 3, 2025
Merged

feat(vite): basic rolldown-vite support #3723

pi0 merged 4 commits into from
Nov 3, 2025

Conversation

@pi0
Copy link
Member

@pi0 pi0 commented Nov 3, 2025 •
edited
Loading

This PR adds basic roldown-vite support to nitro/vite plugin.

Known issues:

  • Nested virtuals resolved with moduleSideEffects do not inherit it and get tree-shaken
    • Workaround by adding moduleSideEffects to parent
  • Native resolver not working (Missing field moduleType)
    • Disabled experimental.enableNativePlugin for now
    • Should investigate and fix later!
  • generatedCode.constBindings is not supported
  • sourcemapExcludeSources is not supported
    • Disabled for rolldown

/cc @sapphi-red @bluwy

@vercel
Copy link

vercel bot commented Nov 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nitro.build Ready Ready Preview Comment Nov 3, 2025 9:56pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/nitrojs/nitro@3723

commit: 4abcc80

@pi0 pi0 requested a review from a team November 3, 2025 22:01
@pi0 pi0 merged commit 2b05994 into main Nov 3, 2025
7 checks passed
@pi0 pi0 deleted the rolldown-vite branch November 3, 2025 22:01
@sapphi-red
Copy link

sapphi-red commented Nov 4, 2025

Nested virtuals resolved with moduleSideEffects do not inherit it and get tree-shaken

  • Workaround by adding moduleSideEffects to parent

@pi0 Would you create an issue with a repro in rolldown-vite repo?

@pi0
Copy link
Member Author

pi0 commented Nov 4, 2025

@sapphi-red yes i will try to make a minimal reproduction. sorry for small pings wanted to keep you in loop.

@pi0 pi0 mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pi0 @sapphi-red