Skip to content

Conversation

@davidk
Copy link
Collaborator

@davidk davidk commented Jul 24, 2023

This set of commits changes ntgrrc CLI arguments to fall more in-line with how poe status and poe settings are currently being used and structured. port set code was also changed to indicate that it belongs in its own separate space.

Other minor updates:

  • README.md updated (following the changed CLI convention)
  • When printing JSON, there should be an indication of where the output comes from (poe settings vs port settings)

@davidk davidk requested a review from nitram509 as a code owner July 24, 2023 08:40
@davidk davidk changed the title Change "port status" to "port settings" and make "port set more explicit Change "port status" to "port settings" and make "port set" more explicit Jul 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #41 (135dcc7) into main (beabeb5) will not change coverage.
The diff coverage is 15.00%.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   41.25%   41.25%           
=======================================
  Files          16       16           
  Lines         863      863           
=======================================
  Hits          356      356           
  Misses        497      497           
  Partials       10       10           
Impacted Files Coverage Δ
port_settings.go 32.14% <0.00%> (ø)
port_set.go 34.84% <33.33%> (ø)
poe_settings.go 70.88% <100.00%> (ø)
poe_status.go 74.15% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidk davidk force-pushed the portStatustoSettings branch from 2ff7de3 to 135dcc7 Compare July 24, 2023 09:55
@davidk davidk merged commit 76795e4 into nitram509:main Jul 25, 2023
@davidk davidk deleted the portStatustoSettings branch July 25, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants