TEST: Drop excessively long interface equivalence tests #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 47.75% 47.75%
=======================================
Files 45 45
Lines 5557 5557
Branches 797 797
=======================================
Hits 2654 2654
Misses 2809 2809
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mgxd
reviewed
Dec 8, 2021
Contributor
mgxd
left a comment
There was a problem hiding this comment.
How much time is this saving?
Member
Author
|
A few minutes. |
mgxd
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know that our method runs faster and uses less memory than nilearn's, so let's take the fastest one and just ensure that we don't lose equivalence.