Skip to content

FIX: DerivativesDataSink dismissing entity writing reportlet #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2021
Merged

FIX: DerivativesDataSink dismissing entity writing reportlet #638

merged 2 commits into from
May 17, 2021

Conversation

@oesteban
Copy link
Member

@oesteban oesteban commented May 16, 2021 •
edited
Loading

This pattern:

niworkflows/niworkflows/data/nipreps.json

Line 156 in 32a33d6

"sub-{subject}/{datatype<figures>}/sub-{subject}[_ses-{session}][_acq-{acquisition}][_ce-{ceagent}][_rec-{reconstruction}][_run-{run}][_space-{space}][_cohort-{cohort}][_desc-{desc}]_{suffix<T1w|T2w|T1rho|T1map|T2map|T2star|FLAIR|FLASH|PDmap|PD|PDT2|inplaneT[12]|angio|dseg|mask|dwi|epiref|fieldmap|T2starw|MTw|TSE>}{extension<.html|.svg>|.svg}",

overshadows the following:

niworkflows/niworkflows/data/nipreps.json

Line 157 in 32a33d6

"sub-{subject}/{datatype<figures>}/sub-{subject}[_ses-{session}][_acq-{acquisition}][_ce-{ceagent}][_rec-{reconstruction}][_run-{run}][_space-{space}][_cohort-{cohort}][_fmapid-{fmapid}][_desc-{desc}]_{suffix<fieldmap>}{extension<.html|.svg>|.svg}",

@oesteban oesteban marked this pull request as ready for review May 17, 2021 08:05
@oesteban oesteban merged commit c233fa7 into master May 17, 2021
@oesteban oesteban deleted the fix/dds-fmapid branch May 17, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oesteban