FIX: Limit memory usage in EstimateReferenceImage #629
Conversation
|
Awesome, thank you! |
|
I'm not sure if you're already on that, but you may want to add the same check here for 1.4.0 niworkflows/niworkflows/interfaces/images.py Lines 269 to 271 in 616d2bc |
|
Although I guess there you will need the full image, so I may be wrong :-) |
|
Yeah, I don't know that we can avoid loading all the data, but we definitely don't need to be making so many copies. |
Codecov Report
@@ Coverage Diff @@
## maint/1.3.x #629 +/- ##
===============================================
+ Coverage 46.94% 47.80% +0.86%
===============================================
Files 43 43
Lines 5287 5290 +3
Branches 770 771 +1
===============================================
+ Hits 2482 2529 +47
+ Misses 2721 2673 -48
- Partials 84 88 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
svgo 2.x dropped support for CLI plugin alteration. We could generate a JSON config with this option, but the changes are so miniscule we can likely just drop this flag.
|
So this is only a smoke test, but it's more than we had, and there doesn't seem to be much point in extensively testing an interface that is removed in the next minor series. I'm going to go ahead and merge. |
|
1.3.3 released. Should hit PyPI in an hour or two. |
Fixes #628. At least partially. If we're splitting and concatenating 900MB of data, it seems plausible we could double our usage to 1.8GB. Maybe should call it 2GB to be safe?