Skip to content

Conversation

@mgxd
Copy link
Contributor

@mgxd mgxd commented Feb 11, 2021

Originally #619 (see #619 (comment))

@effigies
Copy link
Member

The SVGs from before have expired. When they regenerate, could you post them here as attachments to the comment, or screenshots?

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #620 (1f00278) into master (2209cd6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
- Coverage   47.78%   47.77%   -0.01%     
==========================================
  Files          44       44              
  Lines        5485     5486       +1     
  Branches      786      786              
==========================================
  Hits         2621     2621              
- Misses       2770     2771       +1     
  Partials       94       94              
Flag Coverage Δ
reportlettests 100.00% <ø> (ø)
unittests 47.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/viz/utils.py 8.84% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2209cd6...1f00278. Read the comment docs.

@mgxd
Copy link
Contributor Author

mgxd commented Feb 11, 2021

Essentially it seems to now be fixed, instead of dynamic based on window size.

master
this patch

@effigies
Copy link
Member

Hmm. Not ideal.

@mgxd
Copy link
Contributor Author

mgxd commented Feb 12, 2021

When comparing new/current images, it seemed the viewBox element was not being saved. Setting the height / width through svgutils' Unit fixes this, and images are correctly sized again. This should be good now.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for tracking this down.

@mgxd mgxd merged commit 3773012 into nipreps:master Feb 12, 2021
@mgxd mgxd deleted the fix/svgutils branch February 12, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants