Skip to content

ENH: Add a RobustAverage interface and split volume selection #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2021
Merged

ENH: Add a RobustAverage interface and split volume selection #602

merged 4 commits into from
Jan 28, 2021

Conversation

@oesteban
Copy link
Member

@oesteban oesteban commented Jan 27, 2021

Resolves: #600.

@oesteban oesteban requested a review from mgxd January 27, 2021 22:29
@oesteban
Copy link
Member Author

oesteban commented Jan 27, 2021

I'll work on the interface that generates t_list tomorrow.

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #602 (b0e0141) into master (3f8c265) will decrease coverage by 1.18%.
The diff coverage is 68.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   47.89%   46.70%   -1.19%     
==========================================
  Files          44       44              
  Lines        5356     5413      +57     
  Branches      785      791       +6     
==========================================
- Hits         2565     2528      -37     
- Misses       2697     2795      +98     
+ Partials       94       90       -4
Flag Coverage Δ
documentation 0.00% <0.00%> (ø)
masks ?
reportlettests 100.00% <ø> (ø)
unittests 46.89% <68.25%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/interfaces/images.py 66.51% <68.25%> (-3.56%) ⬇️
niworkflows/__init__.py 0.00% <0.00%> (-81.82%) ⬇️
niworkflows/func/util.py 21.17% <0.00%> (-47.06%) ⬇️
niworkflows/interfaces/fixes.py 50.00% <0.00%> (-5.56%) ⬇️
niworkflows/interfaces/utils.py 40.14% <0.00%> (-2.38%) ⬇️
niworkflows/interfaces/report_base.py 47.54% <0.00%> (-1.64%) ⬇️
niworkflows/viz/utils.py 9.52% <0.00%> (+0.02%) ⬆️
niworkflows/interfaces/mni.py 25.86% <0.00%> (+0.14%) ⬆️
niworkflows/utils/bids.py 75.00% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8c265...b0e0141. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jan 28, 2021 •
edited
Loading

Hello @oesteban, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 niworkflows.

Comment last updated at 2021-01-28 15:17:49 UTC

@oesteban oesteban force-pushed the enh/modality-agnostic-ref-600 branch from 4fddc45 to 148af7b Compare January 28, 2021 09:48
@oesteban oesteban marked this pull request as ready for review January 28, 2021 09:48
@oesteban
Copy link
Member Author

oesteban commented Jan 28, 2021

Okay, this is looking better. Please LMKWYT, @mgxd .

@oesteban oesteban force-pushed the enh/modality-agnostic-ref-600 branch from 148af7b to f8dc413 Compare January 28, 2021 12:47
mgxd
mgxd approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but this LGTM

@oesteban @mgxd
Apply suggestions from code review
2f2eb95 
Co-authored-by: Mathias Goncalves <[email protected]>
@oesteban oesteban merged commit d69dd64 into nipreps:master Jan 28, 2021
@oesteban oesteban deleted the enh/modality-agnostic-ref-600 branch January 28, 2021 15:40
@eilidhmacnicol eilidhmacnicol mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgxd mgxd mgxd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make EstimateReference modality-agnostic

4 participants

@oesteban @codecov-io @pep8speaks @mgxd