Skip to content

FIX: Cordon off .dtseries.json contents #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2020
Merged

FIX: Cordon off .dtseries.json contents #578

merged 4 commits into from
Nov 5, 2020

Conversation

@effigies
Copy link
Member

@effigies effigies commented Nov 5, 2020

First step of nipreps/fmriprep#2294.

@pep8speaks
Copy link

pep8speaks commented Nov 5, 2020 •
edited
Loading

Hello @effigies, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 niworkflows.

Comment last updated at 2020-11-05 19:07:03 UTC

@effigies effigies force-pushed the fix/legacy_dtseries_json branch from 7f8269e to 0a0b659 Compare November 5, 2020 14:31
@effigies effigies mentioned this pull request Nov 5, 2020
Merged
@codecov
Copy link

codecov bot commented Nov 5, 2020 •
edited
Loading

Codecov Report

Merging #578 into maint/1.3.x will increase coverage by 0.04%.
The diff coverage is 90.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.3.x     #578      +/-   ##
===============================================
+ Coverage        64.39%   64.44%   +0.04%     
===============================================
  Files               43       43              
  Lines             5278     5287       +9     
  Branches           766      770       +4     
===============================================
+ Hits              3399     3407       +8     
  Misses            1720     1720              
- Partials           159      160       +1
Flag Coverage Δ
documentation 32.78% <0.00%> (-0.06%) ⬇️
reportlettests 100.00% <ø> (ø)
travis 59.28% <90.00%> (+0.05%) ⬆️
unittests 47.14% <90.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/interfaces/bids.py 96.32% <90.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a9cd9...87a93db. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Nov 5, 2020

@mgxd @oesteban Can I trouble one of you for a review? This is passing and can be seen in action in nipreps/fmriprep#2320.

I'm inclined to make a niworkflows bug-fix release with this in.

mgxd
mgxd approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions to keep the code more consistent but feel free to discard.

@effigies
Copy link
Member Author

effigies commented Nov 5, 2020

Sure. I'd kept the old part the same for the simplicity of the edit, but the test makes changing it safer.

mgxd
mgxd reviewed Nov 5, 2020
View reviewed changes
@effigies
Copy link
Member Author

effigies commented Nov 5, 2020

Passes locally now. Thanks for the quick fix.

@effigies effigies merged commit c7c20ea into nipreps:maint/1.3.x Nov 5, 2020
@effigies effigies deleted the fix/legacy_dtseries_json branch December 14, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgxd mgxd mgxd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@effigies @pep8speaks @mgxd