refactor(store): clear _states on destroy to aid GC under high load
#2365
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the internal _states array in StateFactory could retain references after the request completes in SSR environments. While this does not affect client-side SPAs, it can prevent the garbage collector from freeing memory efficiently under high-concurrency SSR load. This commit clears _states when the StateFactory is destroyed, helping reduce memory usage and prevent leaks in server-side rendering scenarios.
|
View your CI Pipeline Execution ↗ for commit 36f0f31
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +201B +0.14% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Unchanged files (1)
Total files change +7B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the internal _states array in StateFactory could retain references after the request completes in SSR environments. While this does not affect client-side SPAs, it can prevent the garbage collector from freeing memory efficiently under high-concurrency SSR load.
This commit clears _states when the StateFactory is destroyed, helping reduce memory usage and prevent leaks in server-side rendering scenarios.