Skip to content

refactor(store): warn when state changes are ignored #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

refactor(store): warn when state changes are ignored #2345

merged 1 commit into from
Jun 16, 2025

Conversation

@arturovt
Copy link
Member

No description provided.

@arturovt arturovt merged commit ae76ef6 into master Jun 16, 2025
2 of 3 checks passed
@arturovt arturovt deleted the refactor/warn-noop branch June 16, 2025 08:19
@nx-cloud
Copy link

nx-cloud bot commented Jun 16, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 162f2dc.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 10s View ↗
nx lint-types store ✅ Succeeded 4s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 08:25:40 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 16, 2025

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2345

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2345

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2345

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2345

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2345

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2345

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2345

commit: 162f2dc

@bundlemon
Copy link

bundlemon bot commented Jun 16, 2025

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 97.1KB 105KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 13.78KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.47KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 31.69KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 16, 2025

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.96KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.63KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.56KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.46KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.14KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.01KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.07KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 16, 2025

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
 66.23KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arturovt