Skip to content

refactor: replace const enum #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

refactor: replace const enum #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247a403
refactor: replace `const enum`
arturovt Jun 3, 2025
79f0c6d
chore: update CHANGELOG.md
arturovt Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ $ npm install @ngxs/store@dev
- Refactor: Reduce RxJS dependency [#2292](https://github.com/ngxs/store/pull/2292)
- Refactor: Pull less RxJS symbols [#2309](https://github.com/ngxs/store/pull/2309) [#2310](https://github.com/ngxs/store/pull/2310)
- Refactor: Replace `ENVIRONMENT_INITIALIZER` [#2314](https://github.com/ngxs/store/pull/2314)
- Refactor: Replace `const enum` [#2332](https://github.com/ngxs/store/pull/2332)
- Refactor: Replace `const enum` [#2335](https://github.com/ngxs/store/pull/2335)
- Fix(store): Add root store initializer guard [#2278](https://github.com/ngxs/store/pull/2278)
- Fix(store): Reduce change detection cycles with pending tasks [#2280](https://github.com/ngxs/store/pull/2280)
- Fix(store): Complete action results on destroy [#2282](https://github.com/ngxs/store/pull/2282)
Expand Down
11 changes: 4 additions & 7 deletions packages/router-plugin/internals/src/symbols.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@ import { InjectionToken } from '@angular/core';

declare const ngDevMode: boolean;

export const NavigationActionTiming = {
PreActivation: 1,
PostActivation: 2
} as const;

export type NavigationActionTiming =
(typeof NavigationActionTiming)[keyof typeof NavigationActionTiming];
export enum NavigationActionTiming {
PreActivation = 1,
PostActivation = 2
}

export interface NgxsRouterPluginOptions {
navigationActionTiming?: NavigationActionTiming;
Expand Down
10 changes: 4 additions & 6 deletions packages/storage-plugin/internals/src/symbols.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@ export const ɵDEFAULT_STATE_KEY = '@@STATE';

declare const ngDevMode: boolean;

export const StorageOption = {
LocalStorage: 0,
SessionStorage: 1
} as const;

export type StorageOption = (typeof StorageOption)[keyof typeof StorageOption];
export enum StorageOption {
LocalStorage,
SessionStorage
}

export interface NgxsStoragePluginOptions {
/**
Expand Down
14 changes: 6 additions & 8 deletions packages/store/src/actions-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@ import { InternalNgxsExecutionStrategy } from './execution/execution-strategy';
/**
* Status of a dispatched action
*/
export const ActionStatus = {
Dispatched: 'DISPATCHED',
Successful: 'SUCCESSFUL',
Canceled: 'CANCELED',
Errored: 'ERRORED'
} as const;

export type ActionStatus = (typeof ActionStatus)[keyof typeof ActionStatus];
export enum ActionStatus {
Dispatched = 'DISPATCHED',
Successful = 'SUCCESSFUL',
Canceled = 'CANCELED',
Errored = 'ERRORED'
}

export interface ActionContext<T = any> {
status: ActionStatus;
Expand Down
Loading