refactor(store): make execution stategies tree-shakable #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 22814a9.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 7036d7f.
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
7036d7f to
f9c4d73
Compare
|
Code Climate has analyzed commit f9c4d73 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
NGXS has moved towards reducing bundle size by removing unnecessary code in production.
Currently, execution strategies are not tree-shakable because they are explicitly
referenced in the code. We should invert control and require developers to explicitly
provide an execution strategy.
When zoneless change detection is enabled and `NoopNgxsExecutionStrategy` is used,
`DispatchOutsideZoneNgxsExecutionStrategy` remains in the initial bundle, increasing
the final size even though it is never used — and vice versa.
With this commit, we make `options` a required parameter and `options.executionStrategy` a
required property, ensuring that developers always specify an execution strategy.
**BREAKING CHANGE**: The `options` parameter is now required when calling `forRoot()` or
`provideStore()`, as developers must provide an execution strategy. This should be a
straightforward change, as developers only need to specify
`{ executionStrategy: DispatchOutsideZoneNgxsExecutionStrategy }`.
f9c4d73 to
22814a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGXS has moved towards reducing bundle size by removing unnecessary code in production.
Currently, execution strategies are not tree-shakable because they are explicitly
referenced in the code. We should invert control and require developers to explicitly
provide an execution strategy.
When zoneless change detection is enabled and
NoopNgxsExecutionStrategyis used,DispatchOutsideZoneNgxsExecutionStrategyremains in the initial bundle, increasingthe final size even though it is never used — and vice versa.
With this commit, we make
optionsa required parameter andoptions.executionStrategyarequired property, ensuring that developers always specify an execution strategy.
BREAKING CHANGE: The
optionsparameter is now required when callingforRoot()orprovideStore(), as developers must provide an execution strategy. This should be astraightforward change, as developers only need to specify
{ executionStrategy: DispatchOutsideZoneNgxsExecutionStrategy }.