refactor(store): rely on ngDevMode to be always defined
#2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates all `ngDevMode` conditions to remove the check for `ngDevMode` being `undefined`. We can ensure it's always defined by Angular since VE has been dropped. However, the `typeof` check is still necessary to ensure code safety, as `ngDevMode` is a global variable provided by the framework.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6bbdf0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (1)
Unchanged files (1)
Total files change +11B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit 6bbdf0d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates all
ngDevModeconditions to remove the check forngDevModebeingundefined. We can ensure it's always defined by Angular since VE has been dropped. However, thetypeofcheck is still necessary to ensure code safety, asngDevModeis a global variable provided by the framework.