fix(store): setState and patchState should both return <void>
#2114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the signatures of `setState` and `patchState` to return `<void>`. Previously, they were returning `<T>`, which was historically a mistake. This change also impacts the `Store.reset` method since it utilizes `setState`, resulting in `Store.reset` now also returning `<void>`. `setState` is designed to update the state, and as such, the method itself should not generate a return value. Users should utilize `getState` to retrieve the latest value accordingly.
18 tasks
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8fd33d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
BundleMon (Integration Projects)Unchanged files (2)
Total files change +8B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit 8fd33d7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the signatures of
setStateandpatchStateto return<void>. Previously, they were returning<T>, which was historically a mistake. This change also impacts theStore.resetmethod since it utilizessetState, resulting inStore.resetnow also returning<void>.setStateis designed to update the state, and as such, the method itself should not generate a return value. Users should utilizegetStateto retrieve the latest value accordingly.