docs: example code not compiling #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector
markwhitfeld
approved these changes
Sep 26, 2023
markwhitfeld
pushed a commit
that referenced
this pull request
Nov 10, 2023
* docs: example code not compiling (#2059) The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector * Update installation.md Added snippet for installing the devtools plugin. --------- Co-authored-by: benoitnesme <[email protected]>
markwhitfeld
pushed a commit
that referenced
this pull request
Nov 30, 2023
* docs: example code not compiling (#2059) The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector * Update installation.md Added snippet for installing the devtools plugin. --------- Co-authored-by: benoitnesme <[email protected]> (cherry picked from commit d2f9ef4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: fix one Selector code sample that is not compiling
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The provided code sample didn't compile and was misleading, especially because of the lack of [] around AnimalsState in @selector
Issue Number: N/A
What is the new behavior?
The code sample will compile directly when copied to local machine
Does this PR introduce a breaking change?
Other information