fix(store): avoid incorrectly ordered state observable events #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dec353 to
490f97a
Compare
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +108B +0.04% Groups updated (6)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (28)
No change in files bundle size Unchanged groups (6)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (4)
Total files change +237B +0.08% Final result: ✅ View report in BundleMon website ➡️ |
490f97a to
28626e6
Compare
|
Code Climate has analyzed commit 0705334 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Aug 12, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.4/3.7.5) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.4/3.7.5) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | patch | [`3.7.4` -> `3.7.5`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.4/3.7.5) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.7.5`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#​375-2022-08-08) [Compare Source](ngxs/store@v3.7.4...v3.7.5) - Performance: Tree-shake no type on the action error [#​1858](ngxs/store#1858) - Fix: Give back control to `developmentMode` config property [#​1878](ngxs/store#1878) - Fix: Do not use `refCount()` since it makes selectable stream cold [#​1883](ngxs/store#1883) - Fix: Remove `?` from `ctx` parameter of lifecycle hooks since they are never undefined [#​1889](ngxs/store#1889) - Fix: Avoid incorrectly ordered state observable events [#​1908](ngxs/store#1908) - Fix: Router Plugin - Prevent router overriding valid navigation [#​1907](ngxs/store#1907) - Fix: Storage Plugin - Provide more meaningful error message when the storage quota exceeds [#​1863](ngxs/store#1863) - Fix: Storage Plugin - Ensure the deserialization is not skipped for master key [#​1887](ngxs/store#1887) - Fix: Storage Plugin - Do not re-hydrate the whole state when the feature state is added [#​1887](ngxs/store#1887) - Fix: Devtools Plugin - Enable time-traveling for navigation actions [#​1868](ngxs/store#1868) - Fix: Form Plugin - Prevent actions infinite loop with multiple `ngxsForm` directives [#​1890](ngxs/store#1890) - Fix: Do not check if the state class is injectable within the decorator since the `ɵprov` will not exist in JIT mode [#​1867](ngxs/store#1867) - Revert: revert select decorator changes and add deprecation note [#​1871](ngxs/store#1871) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTEuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE1Mi4wIn0=--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1497 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1728
Note:do not emit old values from the stateis a wrong commit name, I just haven't found anything meaningful, this should be renamed.I've updated
tsconfig.spec.jsonto stop warning on unused locals, because it's a pain writing unit tests with these options enabled.