Skip to content

docs: snippets #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2021
Merged

docs: snippets #1769

merged 6 commits into from
Jun 28, 2021

Conversation

@joaqcid
Copy link
Contributor

@joaqcid joaqcid commented Jun 25, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ X ] No

Other information

@splincode
Copy link
Member

splincode commented Jun 25, 2021

update changelog.md please

@markwhitfeld
Copy link
Member

markwhitfeld commented Jun 28, 2021

@splincode Pure docs changes don't go in the changelog.

@splincode splincode merged commit 2dd8523 into ngxs:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@arturovt arturovt Awaiting requested review from arturovt arturovt is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaqcid @splincode @markwhitfeld