Implement wave container commands #3954
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anFlesch/nf-core-tools into feature/3952-create-waveyml
…t instead of printing. simplify checks
…/nf-core-tools into feature/3952-create-waveyml
mashehu
reviewed
Dec 4, 2025
…/nf-core-tools into feature/3952-create-waveyml
mashehu
reviewed
Dec 5, 2025
Comment on lines
+17
to
+19
| IMAGE_KEY = "name" | ||
| BUILD_ID_KEY = "buildId" | ||
| SCAN_ID_KEY = "scanId" |
Contributor
There was a problem hiding this comment.
I don't think any of these will change in the future. clearer if we just use them as strings in the code I think.
Contributor
Author
There was a problem hiding this comment.
If you don't feel strongly about this, I think we should keep them. They only exist in the class scope, close to where they are being used, but there we use them quite a lot as it helps us to not have redundant literals
mashehu
approved these changes
Dec 5, 2025
nf_core/modules/containers.py
Outdated
| for platform in CONTAINER_PLATFORMS: | ||
| containers[cs][platform] = self.request_container(cs, platform, env_path, await_, dry_run) | ||
|
|
||
| for platform in CONTAINER_PLATFORMS: |
Contributor
There was a problem hiding this comment.
do we need to loop twice over container_platforms?
Contributor
Author
There was a problem hiding this comment.
I thought it makes it more readable what's being done with being less nested and clearly separated. But for comparing, applied your suggestion in af97d90
Fix typo Co-authored-by: Matthias Hörtenhuber <[email protected]>
Contributor
Author
|
…n favor of attempting to build it.
mashehu
reviewed
Dec 16, 2025
| fut = pool.submit(self.request_container, cs, platform, self.condafile, await_) | ||
| tasks[fut] = (cs, platform) | ||
|
|
||
| for fut in as_completed(tasks): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3952
PR checklist
CHANGELOG.mdis updateddocsis updated