-
Notifications
You must be signed in to change notification settings - Fork 223
dev -> main for 3.5.0 #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dev -> main for 3.5.0 #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Júlia Mir Pedrol <[email protected]>
utils.get_wf_files has logic for parsing .gitignore files and using the patterns there as an ignore list, but it doesn't implement the full semantics of gitignore patterns. This change adds support for trailing slash which should ignore an entire directory, which is important as such patterns are included in the pipeline TEMPLATE .gitignore. Also, relative path handling is implemented in the ignore pattern checking. This means ignore patterns still work correctly when the -d option is given to lint a directory other than the current one. Finally, .git/* is added as an implicit ignore pattern that is always in effect.
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: nf-core-bot <[email protected]>
…bworkflows Preserve the value of self.modules_repo across nested calls
Co-authored-by: nf-core-bot <[email protected]>
Linting: Add linting of topics
Co-authored-by: Matthias Zepper <[email protected]>
* chore(deps): update actions/checkout digest to 93cb6ef * [automated] Update CHANGELOG.md --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: nf-core-bot <[email protected]>
Co-authored-by: nf-core-bot <[email protected]>
Co-authored-by: Júlia Mir Pedrol <[email protected]> Co-authored-by: Matthias Hörtenhuber <[email protected]>
Improve file ignores in workflow file enumeration
Co-authored-by: Júlia Mir Pedrol <[email protected]> Co-authored-by: nf-core-bot <[email protected]>
Enable CI tests for pipelines/download
Co-authored-by: nf-core-bot <[email protected]>
Update pipeline creation information page to be more exclusive as to what should use the full nf-core pipeline template
mirpedrol
approved these changes
Nov 19, 2025
Member
mirpedrol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.