Skip to content

Linting: Add link to modules and subworkflows linting error docs #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mirpedrol merged 7 commits into from
Oct 9, 2025
Merged

Linting: Add link to modules and subworkflows linting error docs #3818

mirpedrol merged 7 commits into from
Oct 9, 2025

Conversation

@mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Oct 8, 2025 •
edited
Loading

Instead of adding a new column, the test name + link are written at the beginning of the description, like we do with pipelines.

image

Additionally, I have added passed messages where they were missing.

Close #3789

@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 67.96117% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.36%. Comparing base (664696c) to head (a3a2bfb).
⚠️ Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/modules/lint/main_nf.py 52.38% 20 Missing ⚠️
nf_core/modules/lint/module_patch.py 50.00% 2 Missing ⚠️
nf_core/modules/lint/module_version.py 60.00% 2 Missing ⚠️
nf_core/subworkflows/lint/main_nf.py 77.77% 2 Missing ⚠️
nf_core/subworkflows/lint/meta_yml.py 71.42% 2 Missing ⚠️
nf_core/subworkflows/lint/subworkflow_version.py 50.00% 2 Missing ⚠️
nf_core/modules/lint/meta_yml.py 66.66% 1 Missing ⚠️
...ore/subworkflows/lint/subworkflow_if_empty_null.py 50.00% 1 Missing ⚠️
nf_core/subworkflows/lint/subworkflow_tests.py 50.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirpedrol mirpedrol requested a review from a team October 9, 2025 07:16
mashehu
mashehu approved these changes Oct 9, 2025
View reviewed changes
@mirpedrol mirpedrol merged commit e15bf4e into nf-core:dev Oct 9, 2025
116 checks passed
@mashehu mashehu mentioned this pull request Oct 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirpedrol @mashehu @nf-core-bot