Skip to content

Fix/enum backwards compatibility #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 29, 2025
Merged

Fix/enum backwards compatibility #3736

merged 4 commits into from
Aug 29, 2025

Conversation

@JulianFlesch
Copy link
Contributor

@JulianFlesch JulianFlesch commented Aug 29, 2025 •
edited
Loading

Backwards compatibility with Python3.9 was broken by accident in commit f6c7836 that was merged to dev.

Enums were introduced in 3.4 but StrEnum only with 3.11 (Python docs)

This fixes the test (that should be failing but didn't in the PR !?)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@JulianFlesch JulianFlesch requested a review from mirpedrol August 29, 2025 11:22
@JulianFlesch JulianFlesch requested review from a team and removed request for mirpedrol August 29, 2025 11:28
@JulianFlesch JulianFlesch self-assigned this Aug 29, 2025
@codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.74%. Comparing base (6c759f2) to head (15aeedd).
⚠️ Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/download/docker.py 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

maxulysse
maxulysse approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulianFlesch JulianFlesch merged commit e98ae9b into nf-core:dev Aug 29, 2025
120 of 203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees

@JulianFlesch JulianFlesch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JulianFlesch @maxulysse @mirpedrol @nf-core-bot