Refactor download tests (#3634 follow up) #3712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 14, 2025
Contributor
Author
|
Docs updated in nf-core/website#3463 |
Contributor
|
@ErikDanielsson I don't understand this. It seems, there are no new changes left after merging #3706 Was this PR redundant? |
Contributor
Author
|
All changes in this PR merged in #3706 making this PR redundant from now on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on the major download refactor #3634 where I move the tests for the download classes to a separate folder. The motivation is that the
test_download.pywas too big to be manageable. This also has the benefit of not having to rerun all tests if one type of test failsSee ErikDanielsson#3 for the diff with the major refactor branch
PR checklist
CHANGELOG.mdis updateddocsis updated