Merge branch 'download-refactor-again' into move-gather-registries

nf-core · JulianFlesch · Aug 29, 2025 · Jul 31, 2025 · Jul 31, 2025 · Aug 1, 2025
commit b3e1306457f6c39f4d9d4ef55d3398672d7f0d65
diff --git a/nf_core/pipelines/download/download.py b/nf_core/pipelines/download/download.py
@@ -640,7 +640,12 @@ def get_container_output_dir(self) -> Path:
         return self.outdir / f"{self.container_system}-images"
 
     def download_container_images(self, workflow_directory: Path, current_revision: str = "") -> None:
-        """Loop through container names and download Singularity images"""
+        """
+        Fetch the container images with the appropriate ContainerFetcher
+
+        Args:
+            current_revision (str): The current revision of the workflow.
+        """
 
         if len(self.containers) == 0:
             log.info("No container names found in workflow")

diff --git a/tests/pipelines/test_download.py b/tests/pipelines/test_download.py
@@ -905,7 +905,7 @@ def test_singularity_pull_image_successfully(self, tmp_dir, mock_progress):
         singularity_fetcher.check_and_set_implementation()
         singularity_fetcher.progress = mock_progress()
         singularity_fetcher.registry_set = {}
-        singularity_fetcher.pull_image("hello-world", f"{tmp_dir}/yet-another-hello-world.sif", "docker.io")
+        singularity_fetcher.pull_image("hello-world", tmp_dir / "yet-another-hello-world.sif", "docker.io")
 
     #
     # Tests for 'DockerFetcher.pull_and_save_image'