Skip to content

TEMPLATE: Keep pipeline name in version.yml file #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2024
Merged

TEMPLATE: Keep pipeline name in version.yml file #3223

merged 5 commits into from
Oct 15, 2024

Conversation

@maxulysse
Copy link
Member

Why going for pipeline when we have shortname?

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse
keep pipeline name in version.yml file
8ae861d 
Why going for pipeline when we have shortname?
maxulysse
maxulysse commented Oct 14, 2024
View reviewed changes
@maxulysse maxulysse changed the title Keep pipeline name in version.yml file TEMPLATE - Keep pipeline name in version.yml file Oct 14, 2024
@mashehu mashehu changed the title TEMPLATE - Keep pipeline name in version.yml file TEMPLATE: Keep pipeline name in version.yml file Oct 14, 2024
@mashehu
Copy link
Contributor

mashehu commented Oct 14, 2024

@nf-core-bot changelog

@codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (78c9228) to head (18cbf05).
Report is 7 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol reviewed Oct 14, 2024
View reviewed changes
mirpedrol
mirpedrol approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@maxulysse maxulysse enabled auto-merge October 15, 2024 07:54
@maxulysse maxulysse merged commit f2252c5 into dev Oct 15, 2024
83 checks passed
@maxulysse maxulysse deleted the maxulysse-patch-5 branch October 15, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maxulysse @mashehu @mirpedrol @nf-core-bot