Skip to content

List - message if no results, suggest similar but different command #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

List - message if no results, suggest similar but different command #1138

merged 1 commit into from
Jun 30, 2021

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jun 30, 2021

I tried doing a live demo earlier today and ran nf-core list modules. To my confusion, this just returned an empty table.

This PR:

  • Shows a message if no pipelines are found, instead of printing an empty table
  • Shows a bonus help message if modules was the only filter keyword
$ nf-core list modules

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 1.14.dev0



No pipelines found using filter keywords: 'modules'

💡 Did you mean 'nf-core modules list' instead?

@ewels ewels added the command line tools Anything to do with the cli interfaces label Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #1138 (bd4edea) into dev (086e25a) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1138      +/-   ##
==========================================
- Coverage   69.82%   69.75%   -0.08%     
==========================================
  Files          50       50              
  Lines        5173     5174       +1     
==========================================
- Hits         3612     3609       -3     
- Misses       1561     1565       +4
Impacted Files Coverage Δ
nf_core/list.py 80.65% <33.33%> (-1.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086e25a...bd4edea. Read the comment docs.

drpatelh
drpatelh approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@drpatelh drpatelh merged commit ab94d5f into nf-core:dev Jun 30, 2021
@ewels ewels deleted the list-modules branch July 1, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drpatelh drpatelh drpatelh approved these changes

@KevinMenden KevinMenden Awaiting requested review from KevinMenden

@ErikDanielsson ErikDanielsson Awaiting requested review from ErikDanielsson

Assignees

No one assigned

Labels

command line tools Anything to do with the cli interfaces

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewels @drpatelh