Skip to content

Update nf-core modules list to show module versions #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 29, 2021
Merged

Update nf-core modules list to show module versions #1134

merged 7 commits into from
Jun 29, 2021

Conversation

@ErikDanielsson
Copy link
Contributor

@ErikDanielsson ErikDanielsson commented Jun 29, 2021 •
edited
Loading

Updated nf-core modules list to show

  • the commit SHA
  • the commit message
  • the commit date

for the locally installed modules, if the modules.json file is present. If the modules.json file is missing the old version of the list command is shown, i.e. only the names of the installed modules

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jun 29, 2021 •
edited
Loading

Codecov Report

Merging #1134 (21e6fcf) into dev (4c5720d) will increase coverage by 0.08%.
The diff coverage is 67.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1134      +/-   ##
==========================================
+ Coverage   70.57%   70.65%   +0.08%     
==========================================
  Files          48       48              
  Lines        4849     4887      +38     
==========================================
+ Hits         3422     3453      +31     
- Misses       1427     1434       +7
Impacted Files Coverage Δ
nf_core/modules/modules_command.py 77.77% <ø> (ø)
nf_core/modules/list.py 69.49% <60.00%> (+8.38%) ⬆️
nf_core/modules/module_utils.py 76.63% <80.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5720d...21e6fcf. Read the comment docs.

KevinMenden
KevinMenden reviewed Jun 29, 2021
View reviewed changes
KevinMenden
KevinMenden approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@KevinMenden KevinMenden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, nothing to complain about! 👍

Except maybe that it would be nice if we could add some tests as the coverage of list.py dropped quite a bit.

@KevinMenden
Copy link
Contributor

KevinMenden commented Jun 29, 2021

I think the only test we have for list is not used on a directory. So it should be quite straight forward to add a test that runs nf-core modules list on a pipeline repo, which we have in the test_modules.py setUp function anyway. That would be nice!

@ErikDanielsson
Copy link
Contributor Author

ErikDanielsson commented Jun 29, 2021

Thanks for the review @KevinMenden! The test sounds good, I'll add that.

@ErikDanielsson ErikDanielsson merged commit 544d409 into nf-core:dev Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinMenden KevinMenden KevinMenden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ErikDanielsson @KevinMenden