Skip to content

Fix sync. Again. #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewels merged 7 commits into from
May 12, 2021
Merged

Fix sync. Again. #1072

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9241be7
Get rich traceback to use main stderr rich console
ewels May 11, 2021
b20c0c4
Wrap whole sync PR code in try /except
ewels May 11, 2021
5bf75fc
Explicitly disable requests_cache on all sync API calls
ewels May 11, 2021
bcef01a
Move debug log of API response further up the execution
ewels May 11, 2021
45d843e
Better logging of exceptions, fix sync problem
ewels May 11, 2021
67132b8
Merge branch 'master' into fix-sync
ewels May 11, 2021
7b85d4f
Changelog, fix tests
ewels May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move debug log of API response further up the execution
  • Loading branch information
@ewels
ewels committed May 11, 2021
commit bcef01ae910c0f13273d593ab14419ffa19e8864
8 changes: 6 additions & 2 deletions nf_core/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def make_pull_request(self):

while True:
try:
log.debug("Submitting PR to GitHub API")
returned_data_prettyprint = ""
r_headers_pp = ""
with requests_cache.disabled():
Expand All @@ -342,17 +343,20 @@ def make_pull_request(self):
returned_data_prettyprint = r.content
r_headers_pp = r.headers

# Dump the responses to the log just in case..
log.debug(f"PR response from GitHub. Data:\n{returned_data_prettyprint}\n\nHeaders:\n{r_headers_pp}")

# PR worked
if r.status_code == 201:
self.pr_url = self.gh_pr_returned_data["html_url"]
log.debug(f"GitHub API PR worked:\n{returned_data_prettyprint}\n\n{r_headers_pp}")
log.debug(f"GitHub API PR worked, return code 201")
log.info(f"GitHub PR created: {self.gh_pr_returned_data['html_url']}")
break

# Returned 403 error - too many simultaneous requests
# https://github.com/nf-core/tools/issues/911
if r.status_code == 403:
log.debug(f"GitHub API PR failed with 403 error:\n{returned_data_prettyprint}\n\n{r_headers_pp}")
log.debug(f"GitHub API PR failed with 403 error")
wait_time = float(re.sub("[^0-9]", "", str(r.headers.get("Retry-After", 0))))
if wait_time == 0:
log.debug("Couldn't find 'Retry-After' header, guessing a length of time to wait")
Expand Down