Pipeline jinja #880
Merged
Pipeline jinja #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #880 +/- ##
==========================================
+ Coverage 70.52% 70.65% +0.12%
==========================================
Files 33 33
Lines 3651 3673 +22
==========================================
+ Hits 2575 2595 +20
- Misses 1076 1078 +2
Continue to review full report at Codecov.
|
Member
|
Love the idea |
Contributor
|
Okay everything worked fine for me. Run the same commands with this and the old cookiecutter tool.
Will look a bit deeper to be even more on the safe side but so far everything looks good! 👍 |
drpatelh
approved these changes
Mar 16, 2021
Member
Author
|
Approved on Slack ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the pipeline template to use Jinja2 directly instead of cookiecutter, following on from this process for the module template in #878
Makes for cleaner code, nicer file structures (no more file paths with annoying curly braces) and one fewer dependencies.