Skip to content

fixed HISAT2 route #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Dev -> Master for 3.21.0
merged 4 commits into from
May 3, 2022
Merged

fixed HISAT2 route #818

merged 4 commits into from
May 3, 2022

Conversation

@G-Sarah
Copy link
Contributor

@G-Sarah G-Sarah commented May 2, 2022 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 2, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 62744bb

+| ✅ 143 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-05-03 09:36:57

drpatelh
drpatelh reviewed May 3, 2022
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @G-Sarah ! Need to remove pipeline_diagram_grey.png from this PR and add the changes to nf-core-rnaseq_metro_map_grey.png instead.

@G-Sarah
Copy link
Contributor Author

G-Sarah commented May 3, 2022

Oh yeah, I didn't see it took the old name again, thanks for the heads up!

@G-Sarah
Copy link
Contributor Author

G-Sarah commented May 3, 2022

The prettier linting test fails but I didn't touch the incriminated file and the prettier --check . command runs fine on my machine 🤔
What did I miss?

@drpatelh
Copy link
Member

drpatelh commented May 3, 2022

It's ok. I'll fix it! Think it's because I just merged #790

@drpatelh drpatelh merged commit f091ffe into dev May 3, 2022
@G-Sarah
Copy link
Contributor Author

G-Sarah commented May 3, 2022

Thank you! :D

@drpatelh drpatelh deleted the diagram-fix branch September 22, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drpatelh drpatelh drpatelh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G-Sarah @drpatelh