Skip to content

Conversation

@xXFloBaerXx
Copy link

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).

Description of changes

  • Protein download improvements:

    • Filtered out assemblies that do not contain sequences to prevent errors during downstream processing (with debug log prints).
    • Added retry logic for Entrez handles to make downloads more robust against intermittent network or server errors.
    • Protein chunks are now correctly appended rather than overwriting previous chunks in the protein list -> Fixed protein chunk overwriting.
  • Peptide generation improvements:

    • Debug logging now prints all proteins containing invalid amino acids (determined with extended amino acid alphabet).
    • Filtered out all peptides that do not match the basic amino acid alphabet to ensure compatibility with MHCflurry and maintain standardisation across prediction tools.

Tests

  • Pipeline tested with: nextflow run . -profile debug,test,m3 --outdir output without unexpected warnings
  • Pipeline tested on a test condition with 10 Taxa that trigger all added different cases
  • Pipeline tested on a bigger dataset of around 150 taxa (For testing protein download and epitope prediction parallelisation)

@nf-core-bot
Copy link
Member

nf-core-bot commented Sep 3, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@xXFloBaerXx xXFloBaerXx reopened this Nov 17, 2025
@skrakau skrakau mentioned this pull request Nov 28, 2025
11 tasks
@xXFloBaerXx xXFloBaerXx closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants