Skip to content

Conversation

@tillenglert
Copy link
Collaborator

The CI tests for conda are failing. The reasons are:

The PRODIGAL module produces a slightly different output (proteins.tsv.gz). This results in changed tables in following modules.
MHCNuggets produces small rounding differences, which lead to different predictions in these tests, and the prediction log is changed due to a changed path within the file.

I tried to keep the tests, but accessing which profile is run within the test is really time intensive compared to the expected usage of conda (which is either way not recommended).

Therefore for now, I would turn off CI testing using conda.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/metapep branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tillenglert tillenglert requested a review from skrakau November 13, 2024 05:11
Copy link
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be fine for me, if there are no objections from the nf-core core reviewers

@tillenglert tillenglert merged commit ce8101d into nf-core:dev Nov 13, 2024
23 checks passed
@tillenglert tillenglert deleted the Fix_conda_tests branch November 13, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants