Skip to content

Remove obsolete command from README #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dialvarezs merged 3 commits into from
Oct 28, 2025
Merged

Remove obsolete command from README #896

dialvarezs merged 3 commits into from
Oct 28, 2025

Conversation

@dialvarezs
Copy link
Member

@dialvarezs dialvarezs commented Oct 28, 2025

I also fixed a minor things with the samplesheets

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

d4straub
d4straub approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. No CHANGELOG addition? :)
Edit: Uh the ro-crate needs a fix...

@dialvarezs
Copy link
Member Author

dialvarezs commented Oct 28, 2025 •
edited
Loading

Can someone update the rocrate for me?
It seems like GitHub decided to do a massive ban our local internet provider, I can't access anything from raw.githubusercontent.com, even after refreshing the public IP 🥲

@jfy133
Copy link
Member

jfy133 commented Oct 28, 2025

On it!

@dialvarezs dialvarezs merged commit e5ebf2e into nf-core:dev Oct 28, 2025
6 checks passed
@dialvarezs dialvarezs mentioned this pull request Nov 5, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

@jfy133 jfy133 Awaiting requested review from jfy133 jfy133 is a code owner

@prototaxites prototaxites Awaiting requested review from prototaxites prototaxites is a code owner

@muabnezor muabnezor Awaiting requested review from muabnezor muabnezor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dialvarezs @jfy133 @d4straub