Skip to content

Template update for nf-core/tools version 2.11.1 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2024
Merged

Template update for nf-core/tools version 2.11.1 #48

merged 3 commits into from
Jan 4, 2024

Conversation

@kbestak
Copy link
Collaborator

@kbestak kbestak commented Jan 3, 2024 •
edited
Loading

Updated template to 2.11 and resolved conflicts.
#47

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 661c53a

+| ✅ 162 tests passed       |+
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in main.nf.test: Once you have added the required tests, please run the following command to build this file:
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-03 13:04:21

@kbestak kbestak changed the title Merging template updates2.11.1 Merging template updates 2.11.1 Jan 3, 2024
@kbestak kbestak changed the title Merging template updates 2.11.1 Template update for nf-core/tools version 2.11.1 Jan 3, 2024
FloWuenne
FloWuenne approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@FloWuenne FloWuenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kbestak kbestak merged commit 13fbef4 into nf-core:dev Jan 4, 2024
@kbestak kbestak deleted the merging-template-updates2.11.1 branch January 4, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloWuenne FloWuenne FloWuenne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kbestak @FloWuenne @nf-core-bot