Skip to content

Json schema improvements #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Json schema improvements #113

merged 1 commit into from
Mar 25, 2025

Conversation

@kbestak
Copy link
Collaborator

@kbestak kbestak commented Mar 25, 2025

Updated the schema improvements

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/molkart branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nvnieuwk
nvnieuwk approved these changes Mar 25, 2025
View reviewed changes
Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kbestak kbestak linked an issue Mar 25, 2025 that may be closed by this pull request
JSON schema: Molkart #111
Closed
15 tasks
@kbestak kbestak merged commit 17cd243 into nf-core:dev Mar 25, 2025
8 checks passed
@kbestak kbestak deleted the json-schema-improvements branch March 25, 2025 17:00
@FloWuenne FloWuenne added this to the 1.2.0 - Cartography Castle milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.0 - Cartography Castle

Development

Successfully merging this pull request may close these issues.

JSON schema: Molkart

3 participants

@kbestak @nvnieuwk @FloWuenne