Skip to content

Conversation

FloWuenne
Copy link
Collaborator

This PR will update the master branch for the next release 1.1.0 Resolution Road.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/molkart branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

kbestak and others added 30 commits January 3, 2024 09:31
Co-authored-by: Florian Wuennemann <[email protected]>
Merging template updates, dev version bump after release, module update
Co-authored-by: Florian Wuennemann <[email protected]>
@maxulysse
Copy link
Member

you seem to have CI issues, is that planned or normal?

@kbestak
Copy link
Collaborator

kbestak commented Mar 3, 2025

It was not expected, in a template update, I changed the CI and skipped conda only on dev, I opened a PR with the fix: #106

@FloWuenne
Copy link
Collaborator Author

you seem to have CI issues, is that planned or normal?

@maxulysse Not planned. Forgot to disable conda for the full pipeline test. Will make fix and add to this PR 👍🏻 !

@FloWuenne
Copy link
Collaborator Author

@maxulysse All checks green now ✅ !

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor requests

Co-authored-by: Maxime U Garcia <[email protected]>
@FloWuenne FloWuenne mentioned this pull request Mar 5, 2025
11 tasks
@FloWuenne FloWuenne merged commit d33d298 into master Mar 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants