Skip to content

Conversation

@drpatelh
Copy link
Member

nf-core/chipseq pull request

Many thanks for contributing to nf-core/chipseq!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maaaybe could be nice to list updated packages in the changelog but super minor

@drpatelh
Copy link
Member Author

Done 801bc53

@ewels
Copy link
Member

ewels commented Apr 22, 2021

@drpatelh drpatelh merged commit 6924b66 into master Apr 22, 2021
@drpatelh drpatelh mentioned this pull request Apr 22, 2021
@drpatelh drpatelh deleted the patch branch April 23, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants