Added in xkeys support, which are encoded x25519 keys. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 162
💛 - Coveralls |
Pull Request Test Coverage Report for Build 152
💛 - Coveralls |
73c33d0 to
9f69aec
Compare
philpennock
requested changes
Dec 5, 2022
Member
philpennock
left a comment
There was a problem hiding this comment.
Beware that there are attacks when supplied with private keys and public keys which don't actually correspond to them, and until now we've been resilient because we've always used the seed to generate both at the same time.
Beware that the seed is not the private key, but the rand source for generating the keypair.
Member
Author
|
Not following this comment.. |
philpennock
previously approved these changes
Dec 5, 2022
Member
philpennock
left a comment
There was a problem hiding this comment.
My mistake. I thought our "seeds" were seeds for initializing a CSPRNG to read some number of octets from it, not the private key and a replacement source for reading from. Okay, LGTM. (Obligatory: I am not a cryptographer)
Also added in support for nacl.Box compatibility for Seal and Open. We pick a random nonce for the user via a random source. We may add in other ways to encrypt data for larger messages and multiple recipients in the future. Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Member
Author
|
Squashed, once green will merge. |
philpennock
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added in support for nacl.Box compatibility for Seal and Open, but we pick a random nonce for the user via a random source and append for the user to avoid any bad practices.
Nacl is not the most modern approach, but has broad adoption which was a factor regarding encrypted external authorization callouts.
We may add in other ways to encrypt data for larger messages and multiple recipients in the future.
Signed-off-by: Derek Collison [email protected]