Skip to content

Create dependencies.md [ci skip] #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gcolliso wants to merge 3 commits into from
Closed

Create dependencies.md [ci skip] #29

gcolliso wants to merge 3 commits into from

Conversation

@gcolliso
Copy link
Member

@gcolliso gcolliso commented Jan 6, 2021

No description provided.

@coveralls
Copy link

coveralls commented Jan 6, 2021

Pull Request Test Coverage Report for Build 128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.671%
Totals Coverage Status
Change from base Build 126: 0.0%
Covered Lines: 303
Relevant Lines: 371
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.671%
Totals Coverage Status
Change from base Build 126: 0.0%
Covered Lines: 303
Relevant Lines: 371
💛 - Coveralls

@derekcollison
Copy link
Member

derekcollison commented Nov 30, 2022

Could you update this to most current versions?

derekcollison
derekcollison approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekcollison
derekcollison reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not for this library. They are for the TS/JS one.

@derekcollison
Copy link
Member

derekcollison commented Dec 13, 2022

Also change to merge to main, not master.

@gcolliso
Copy link
Member Author

gcolliso commented Dec 13, 2022

So as these are the same as the previous in 2021, you're saying the file from 2021 was incorrect?

@derekcollison
Copy link
Member

derekcollison commented Dec 13, 2022

No but would squash the two commits since the first was wrong.

@gcolliso gcolliso mentioned this pull request Dec 14, 2022
Merged
@gcolliso
Copy link
Member Author

gcolliso commented Dec 14, 2022

closing this PR - updated with PR #39

@gcolliso gcolliso closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gcolliso @coveralls @derekcollison