Skip to content

fix: find vite client path from subframe parent #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: find vite client path from subframe parent #386

merged 1 commit into from
Aug 11, 2023

Conversation

@cuebit
Copy link
Contributor

@cuebit cuebit commented Aug 11, 2023 •
edited
Loading

closes #384
closes #237

arashsheyda
arashsheyda approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@arashsheyda arashsheyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will also close #237 too

@antfu antfu merged commit e28606a into nuxt:main Aug 11, 2023
Dev1436 pushed a commit to Dev1436/devtools that referenced this pull request Aug 12, 2023
@cuebit @Dev1436
fix: find vite client path from subframe parent (nuxt#386)
28deaa6
Dev1436 pushed a commit to Dev1436/devtools that referenced this pull request Aug 12, 2023
@cuebit @Dev1436
fix: find vite client path from subframe parent (nuxt#386)
54344d7
@cuebit cuebit mentioned this pull request Aug 17, 2023
Closed
@codehead codehead mentioned this pull request Nov 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arashsheyda arashsheyda arashsheyda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: [vite-plugin-hot] Failed to import "/@vite/client" when using nuxt.config "app/buildAssetsDir" Is it possible to change the iframe url?

3 participants

@cuebit @arashsheyda @antfu