[CI] Add stable and latest tags #3826
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Sep 30, 2025
.github/workflows/mark-stable.yaml
Outdated
Comment on lines
116
to
118
| else | ||
| echo "::error::Version tag v${{ github.event.inputs.version }} does not exist in the repository." | ||
| exit 1 |
There was a problem hiding this comment.
If the version doesn't exist, the previous step will fail in docker pull too, but I am not sure a docker pull failure will fail the step itself.
I suggest running the stable tag step first to ensure we fail fast if needed.
There was a problem hiding this comment.
I think we can run them independently as it can be that for some reason one of tags somewhere isn't found(which is not likely, but technically is possible, so we can run again without thinking about the execution order)
|
During testing of my work I found out that if newest version contains workflow changes, github doesn't allow updating unless PAT is used: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the CI as follows:
On every release, a latest tag will now be published alongside the versioned tag.
Introduces a new workflow for marking a GA version as stable.
This workflow re-tags the specified version’s images as stable, pushes them to the registry, and automatically opens a PR updating the stable badge in the README on GitHub. The PR description includes a note reminding maintainers to manually update the stable tag to the desired version. Manual action is required due to the issue described in #3826 (comment), where a Personal Access Token (PAT) is necessary for pushing changes that modify GitHub workflows.
✅ Checklist
🧪 Testing
gonna test after merge fully
🔗 References
🚨 Breaking Changes?