[Wrapper] Support awaitable entrypoint output for a sync function #3810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
approved these changes
Sep 17, 2025
| # stream=f) | ||
| # profiled_serve_requests_func(num_requests=num_of_events) | ||
| # self.assertEqual(num_of_events, self._wrapper._entrypoint.call_count, 'Received unexpected number of events') | ||
| async def _collect_packets_async(self, entrypoint_output): |
There was a problem hiding this comment.
add newline before function
|
@TomerShor I reworked logic of whether to await or not and added |
weilerN
approved these changes
Sep 18, 2025
rokatyy
added a commit
to rokatyy/nuclio
that referenced
this pull request
Sep 18, 2025
…clio#3810) ### 📝 Description While adding support for streaming (=handler as generators), one of the usecases of sync functions got lost. Namely, the one that is used in mlrun, where handler returns coroutine which later need to be awaited on. This pr ensures that this case is supported and added a test for it to make sure. --- ### 🛠️ Changes Made * fixed the bug * added a test * also, not related to the bug itself, but made sure that all tests are sync as unittest tests should be sync, so wrapped them where needed into `asyncio.run` and added some syntactic sugar --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR --- ### 🧪 Testing UT and test on vmdev(see additional notes) --- ### 🔗 References - Ticket link: https://iguazio.atlassian.net/browse/NUC-594 - Design docs links: - External links: --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes Before fix: <img width="2383" height="956" alt="image" src="https://github.com/user-attachments/assets/47ef15b1-40cb-49eb-88f8-b321797f3cfd" /> After: <img width="2232" height="1119" alt="image" src="https://github.com/user-attachments/assets/f261006c-d9e4-4bfc-a187-114f211add90" />
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
While adding support for streaming (=handler as generators), one of the usecases of sync functions got lost. Namely, the one that is used in mlrun, where handler returns coroutine which later need to be awaited on. This pr ensures that this case is supported and added a test for it to make sure.
🛠️ Changes Made
asyncio.runand added some syntactic sugar✅ Checklist
🧪 Testing
UT and test on vmdev(see additional notes)
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes
Before fix:
After:
